[PATCH] D130436: [BOLT] Process each block only once in fixCFGForPIC

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 24 18:17:04 PDT 2022


maksfb added a comment.

Thanks for improving the efficiency of `fixCFGForPIC()`. The change looks fine to me. Do you think the implementation will be simpler if we make `Blocks` a queue and add newly added blocks to the end? This way we can get rid of the inner loop and dealing with `CurrentBB`/`NextBB`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130436/new/

https://reviews.llvm.org/D130436



More information about the llvm-commits mailing list