[PATCH] D130239: [LoongArch] Encode LoongArch specific ELF e_flags to binary by LoongArchTargetStreamer

[Lu Weining via Phabricator via llvm-commits]

SixWeining added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCTargetDesc.cpp:125
+}
+} // end anonymous namespace
+
----------------
MaskRay wrote:
> Below you use `end namespace`.  Be consistent.
Thanks.

And another issue: 2 formats are used currently:
1. // end xxx namespace
2. // namespace xxx

Let me fix it in a seperate NFC patch. 


================
Comment at: llvm/test/CodeGen/LoongArch/e_flags.ll:10
+
+;; LP64D: Flags: 0x3, LP64, DOUBLE-FLOAT
+;; ILP32D: Flags: 0x7, ILP32, DOUBLE-FLOAT
----------------
MaskRay wrote:
> Use single `;` for RUN and CHECK lines.
Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130239/new/

https://reviews.llvm.org/D130239