[llvm] 5bbe452 - Revert "[Orc] Use default member initialization (NFC)"

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 23 21:10:19 PDT 2022


Author: Kazu Hirata
Date: 2022-07-23T21:10:10-07:00
New Revision: 5bbe452e75d464d02547cef0ea2919c53b693f54

URL: https://github.com/llvm/llvm-project/commit/5bbe452e75d464d02547cef0ea2919c53b693f54
DIFF: https://github.com/llvm/llvm-project/commit/5bbe452e75d464d02547cef0ea2919c53b693f54.diff

LOG: Revert "[Orc] Use default member initialization (NFC)"

This reverts commit d534967b6667c468b12e9ed5e3c482f590dde633.

The patch causes build failures, such as:

https://lab.llvm.org/buildbot/#/builders/121/builds/21760

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.cpp b/llvm/lib/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.cpp
index 145d4c61de8c2..75cc30753f416 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.cpp
@@ -28,12 +28,12 @@ class EPCGenericJITLinkMemoryManager::InFlightAlloc
   // We should be able to switch this back to member initialization once that
   // issue is fixed.
   struct SegInfo {
-    SegInfo() = default;
+    SegInfo() : WorkingMem(nullptr), ContentSize(0), ZeroFillSize(0) {}
 
-    char *WorkingMem = nullptr;
+    char *WorkingMem;
     ExecutorAddr Addr;
-    uint64_t ContentSize = 0;
-    uint64_t ZeroFillSize = 0;
+    uint64_t ContentSize;
+    uint64_t ZeroFillSize;
   };
 
   using SegInfoMap = AllocGroupSmallMap<SegInfo>;


        


More information about the llvm-commits mailing list