[PATCH] D130426: [CodeGen] Fixed ambiguous symbol `ExtAddrMode` in case of NDEBUG and LLVM_ENABLE_DUMP

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 23 11:39:07 PDT 2022


barannikov88 added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2580
 
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+#if !defined(NDEBUG) && defined(LLVM_ENABLE_DUMP)
 void ExtAddrMode::print(raw_ostream &OS) const {
----------------
It should be left as it was. The intention is to allow printing if //either// of the macros is defined:
`option(LLVM_ENABLE_DUMP "Enable dump functions even when assertions are disabled" OFF)`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130426/new/

https://reviews.llvm.org/D130426



More information about the llvm-commits mailing list