[PATCH] D130426: [CodeGen] Fixed ambiguous symbol `ExtAddrMode` in case of NDEBUG

[Dmitry Vassiliev via Phabricator via llvm-commits]

slydiman added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2618
 
+} // end anonymous namespace
+
----------------
barannikov88 wrote:
> Please refer to [[ https://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding style ]], in particular:
> > Because of this, we have a simple guideline: make anonymous namespaces as small as possible, and only use them for class declarations.
> 
It seems the function void ExtAddrMode::print() is related to the struct ExtAddrMode declared above inside the anonymous namespace.
Please correct me if I'm wrong. Do you have any suggestions how to fix this error other way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130426/new/

https://reviews.llvm.org/D130426