[PATCH] D123623: [Debuginfo][llvm-dwarfutil] Add check for unsupported debug sections.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:2427-2430
+      reportError(".debug_rnglists is not currently supported",
+                  OptContext.File);
+      OptContext.Skip = true;
+      continue;
----------------
JDevlieghere wrote:
> I generally expect errors to be fatal. Should this be a warning instead? Something like:
> 
> > warning: .debug_rnglists is not currently supported: section will be skipped
> 
> 
I used error vs warning to differentiate a case when 'critical' or not 'critical' section is met. But I think it could be done by different message instead:


```
warning: .debug_rnglists is not currently supported: compile unit will be skipped

```
vs


```
warning: .gdb-index is not currently supported: section will be skipped
```

thus, will make both cases to be warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123623/new/

https://reviews.llvm.org/D123623