[PATCH] D130391: revert "[CodeGen] Require a name for a block addr target"

Fri Jul 22 15:31:22 PDT 2022

nickdesaulniers added inline comments.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:216-217
 ArrayRef<MCSymbol *> AddrLabelMap::getAddrLabelSymbolToEmit(BasicBlock *BB) {
   assert(BB->hasAddressTaken() &&
          "Shouldn't get label for block without address taken");
   AddrLabelSymEntry &Entry = AddrLabelSymbols[BB];
----------------
Note: we already assert, so having a conditional later is pointless.  I suspect the assert was added after 79176a2542d03107b90613c84f18ccba41ad8fa8 (but haven't checked the git log) and that this should have been fixed up when the assert was added.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130391/new/

https://reviews.llvm.org/D130391