[PATCH] D130315: [DWARF][BOLT] Implement new mechanism for DWARFRewriter

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: bolt/lib/Rewrite/DIEBuilder.cpp:120
+DIEBuilder::DIEBuilder(DWARFContext *DwarfContext, bool IsDWO) {
+  if (!DwarfContext)
+    return;
----------------
When will DwarfContext be null?


================
Comment at: bolt/lib/Rewrite/DIEBuilder.cpp:180
+      CloneUnitCtxMap.resize(CloneUnitCtxMap.size() + 1);
+      UnitDIEId.resize(UnitDIEId.size() + 1);
+      DUList.push_back(DU.get());
----------------
Where is  UnitDIEId actually used?


================
Comment at: bolt/lib/Rewrite/DIEBuilder.cpp:304
+    DWARFDebugInfoEntry &DwarfDebugInfoEntry,
+    std::vector<DWARFUnit *> &DUOffsetList) {
+  assert(RefValue.isFormClass(DWARFFormValue::FC_Reference));
----------------



================
Comment at: bolt/lib/Rewrite/DIEBuilder.cpp:382
+        curDIEInfo,
+        std::make_unique<ForwardReferenceInfo>(&DieInfo, AttrSpec)));
+
----------------
Does this need to be a unique_ptr? Can we just store a struct itself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130315/new/

https://reviews.llvm.org/D130315