[PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes
David Truby via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 22 14:58:43 PDT 2022
DavidTruby added a comment.
Essentially I went with Constant because there were significantly more cases where `getIntPtrConstant` was used to construct the argument here than `getTargetConstant`. I'd be pretty happy with either as long as its consistent though! I suppose if it works correctly an i1 `TargetConstant` would probably make the most logical sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130370/new/
https://reviews.llvm.org/D130370
More information about the llvm-commits
mailing list