[PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 13:34:40 PDT 2022

Previous message: [PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes
Next message: [PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

arsenm added a comment.

I think this should consistently be an i32 TargetConstant. There’s no reason to change it based on the pointer type or target


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130370/new/

https://reviews.llvm.org/D130370

Previous message: [PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes
Next message: [PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list