[PATCH] D130316: [SelectionDAG] make INLINEASM_BR use MachineBasicBlocks instead of BlockAddresses

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5293
+        cast<CallBrInst>(&Call)->getBlockAddressForIndirectDest(LabelNo);
+      OpInfo.CallOperandVal = BA->getBasicBlock();
       OpInfo.ConstraintVT =
----------------
nikic wrote:
> This is a roundabout way of saying `cast<CallBrInst>(&Call)->getIndirectDest(LabelNo)` -- unless the fact that a BlockAddress on the IR level is created is still important for something?
Actually, it might be for some of the follow up reverts. I wonder if this is what's creating all of the .Ltmp labels that no longer seem necessary...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130316/new/

https://reviews.llvm.org/D130316