[PATCH] D130291: [DirectX backend] [NFC]Add DXILOpBuilder to generate DXIL operation

[Justin Bogner via Phabricator via llvm-commits]

bogner added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILOpBuilder.cpp:54
+  DXIL_HANDLE,
+};
+} // namespace
----------------
It's awkward to duplicate this enum and split the helpers relating to it between TableGen and Target. Are we likely to need to share more of this type of thing?

There is *some* precedent for sharing by moving some enums and such to Support (see include/llvm/Support/X86DisassemblerDecoderCommon.h), though that does seem like a bit of a hack


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130291/new/

https://reviews.llvm.org/D130291