[PATCH] D130238: [LoongArch] Parse LoongArch base ABI in ObjectYAML and llvm-readobj

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Looks great!



================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:920
+  EF_LOONGARCH_BASE_ABI_ILP32D = 0x7, // ILP32 double-float ABI
+  EF_LOONGARCH_BASE_ABI_MASK = 0x7    // Mask for selecting base ABI
+};
----------------
Add a comma for the last element so that when a new one is added, the contributor doesn't have to touch the mask line.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/loongarch-eflags.test:27
+
+# READOBJ-LP64S: Flags [ (0x1)
+# READOBJ-LP64S-NEXT: EF_LOONGARCH_BASE_ABI_LP64S (0x1)
----------------
Align `Flags` with `]` 2 lines below. For readability, indent `EF_LOONGARCH_BASE_ABI_LP64S` by 2 spaces


================
Comment at: llvm/test/tools/obj2yaml/ELF/loongarch-eflags.yaml:30
+  Flags:           [ EF_LOONGARCH_BASE_ABI_[[FLAG]] ]
+...
----------------
You can delete `...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130238/new/

https://reviews.llvm.org/D130238