[PATCH] D130046: [DWP][DWARF] Detect and error on debug info offset overflow
Alexander Yermolovich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 22 12:04:16 PDT 2022
ayermolo added inline comments.
================
Comment at: llvm/lib/DWP/DWP.cpp:684
+ if (std::numeric_limits<uint32_t>::max() - InfoSectionOffset < C.Length)
+ return make_error<DWPError>("Debug Info offset greater then 4GB.");
+
----------------
MaskRay wrote:
> No capitalization or trailing period for diagnostics: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
>
> At least the following DWPError follows this generic guideline
ok, will revert and put up a new diff with error message that follows the guideline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130046/new/
https://reviews.llvm.org/D130046
More information about the llvm-commits
mailing list