[llvm] 417738d - [DWP][DWARF] Detect and error on debug info offset overflow

[Alexander Yermolovich via llvm-commits]

Author: Alexander Yermolovich
Date: 2022-07-22T10:45:28-07:00
New Revision: 417738d3a66cc65f3fc58ab9535c17fac1ddaff1

URL: https://github.com/llvm/llvm-project/commit/417738d3a66cc65f3fc58ab9535c17fac1ddaff1
DIFF: https://github.com/llvm/llvm-project/commit/417738d3a66cc65f3fc58ab9535c17fac1ddaff1.diff

LOG: [DWP][DWARF] Detect and error on debug info offset overflow

Right now we silently overflow uint32_t for debug_indfo sections. Added a check
and error out.

Differential Revision: https://reviews.llvm.org/D130046

Added: 
    

Modified: 
    llvm/lib/DWP/DWP.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DWP/DWP.cpp b/llvm/lib/DWP/DWP.cpp
index 44e39c019e0ca..4a2053b3a7655 100644
--- a/llvm/lib/DWP/DWP.cpp
+++ b/llvm/lib/DWP/DWP.cpp
@@ -18,6 +18,7 @@
 #include "llvm/Object/Decompressor.h"
 #include "llvm/Object/ELFObjectFile.h"
 #include "llvm/Support/MemoryBuffer.h"
+#include <limits>
 
 using namespace llvm;
 using namespace llvm::object;
@@ -679,6 +680,9 @@ Error write(MCStreamer &Out, ArrayRef<std::string> Inputs) {
               continue;
           }
           Out.emitBytes(Info.substr(UnitOffset - C.Length, C.Length));
+          if (std::numeric_limits<uint32_t>::max() - InfoSectionOffset < C.Length)
+            return make_error<DWPError>("Debug Info offset greater then 4GB.");
+
           InfoSectionOffset += C.Length;
         }
       }