[PATCH] D130187: [Symbolizer] Implement data symbolizer markup element.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

One small comment on the test, I'll be out on vacation next week so may be slow to respond. I've not got any objections so please don't wait for me if others are happy to approve.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-data.test:17
+
+ERR: error: expected 1 field(s); found 0
+ERR: error: no mmap covers address
----------------
Possibly worth a test with too many fields?


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-data.test:32
+  .long 0x11223344
+  .size l, 4
+byte:
----------------
I can't see a label `l` in the test. Was the intention to set the size of long to 4? If so I think you'll need `.size long, 4`. The same applies to `.size b, 1` below.

Checking the object file the sizes of `long` and `byte` are 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130187/new/

https://reviews.llvm.org/D130187