[PATCH] D129545: [RISCV] Scalarize binop followed by extractelement.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 07:32:04 PDT 2022


reames added a comment.

In D129545#3670606 <https://reviews.llvm.org/D129545#3670606>, @craig.topper wrote:

> In D129545#3670596 <https://reviews.llvm.org/D129545#3670596>, @reames wrote:
>
>> In D129545#3670364 <https://reviews.llvm.org/D129545#3670364>, @jacquesguan wrote:
>>
>>> ping.
>>
>> This has already been approved.  Do you have commit access or do you need someone to land on your behalf?
>
> Phabricator does not say it’s approved. Guess you missed changing the status?

Per our dev policy, review status is not authoritative.  I'd previous given an "LGTM".  That means "approved".  This is long standing policy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129545/new/

https://reviews.llvm.org/D129545



More information about the llvm-commits mailing list