[PATCH] D130162: [AArch64][NFC] Add test case for setcc (iN bitcast (vNi1 X)), (iN 0), eq

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-setcc.ll:4
+
+define <8 x i1> @combine_setcc_vecreduce_or_v8i1(<8 x i8> %a) {
+; CHECK-LABEL: combine_setcc_vecreduce_or_v8i1:
----------------
Given these are reduction tests, what's the reason for returning a vector type? I think returning `i1` is more in keeping with real world usage and removes some of the weirdness seen when returning the larger vector i1 types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130162/new/

https://reviews.llvm.org/D130162