[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 07:04:28 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/v8i1-masks.ll:154
+; X32-AVX2-NEXT:    vpbroadcastd {{.*#+}} ymm1 = [1,1,1,1,1,1,1,1]
+; X32-AVX2-NEXT:    vpand %ymm1, %ymm0, %ymm0
 ; X32-AVX2-NEXT:    retl
----------------
deadalnix wrote:
> deadalnix wrote:
> > This is new :(
> @RKSimon I was able to reduce this to D129641 . This regression didn't exist before D129641 , but it does now.
Sorry I should have said - yes this is caused by more yak shaving. I have a large number of other patches in flight that should help, but I'll add this one to the list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list