[PATCH] D125784: [llvm-dva] 09 - CodeView Reader

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 04:42:31 PDT 2022


CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp:118
+namespace logicalview {
+
+// Keeps the type indexes with line information.
----------------
psamolysov wrote:
> The definitions below are used in the `LVCodeViewVisitor.cpp` file only. What if to put them in the anonymous namespace?
Definitions moved to anonymous namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784



More information about the llvm-commits mailing list