[PATCH] D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/test/COFF/exclude-symbols-embedded.s:24-25
+.section .drectve,"yn"
+.ascii " -exclude-symbols:sym2"
+.ascii " -exclude-symbols:sym3"
+
----------------
mati865 wrote:
> Maybe one of these lines should list multiple symbols to cover that case?
Sure, I can extend the test to cover that too. I was a little on the fence regarding whether we should allow multiple symbols in the object files (there’s probably little reason to ever use it), but the binutils review seems to point towards keeping that aspect too, so let’s formalize it in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130120/new/

https://reviews.llvm.org/D130120