[PATCH] D129989: [AArch64] Add f16 fpimm patterns

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 02:54:57 PDT 2022


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.

> I've checked and FMOVWHr does require HasFullFP16 so the question becomes, should we allow good code generation even for the case when HasFullFP16 is not available? Or is HasFullFP16 so universally available these days for us not to care?

I think it's fine for this patch. It's a nice general improvement for when fp16 is available, and fixes the original issue of recognizing scalable splat constants.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129989/new/

https://reviews.llvm.org/D129989



More information about the llvm-commits mailing list