[PATCH] D129751: [AArch64][SVE] Add patterns to select masked add/sub instructions

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 01:46:21 PDT 2022


c-rhodes marked 2 inline comments as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:340-341
+                              (sub node:$op2, node:$op1)>;
+def AArch64subr : PatFrag<(ops node:$pred, node:$op1, node:$op2),
+                          (int_aarch64_sve_subr node:$pred, node:$op1, node:$op2)>;
+def AArch64add : PatFrags<(ops node:$pred, node:$op1, node:$op2),
----------------
paulwalker-arm wrote:
> Is this strictly required? There's only a single pattern and no operand shuffling going on so I think not.
> Is this strictly required? There's only a single pattern and no operand shuffling going on so I think not.

Nope, not sure was I was thinking there, removed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129751/new/

https://reviews.llvm.org/D129751



More information about the llvm-commits mailing list