[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 00:33:33 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/sse41.ll:1160
 
+; FIXME: This could be 'pshufb {{.*#+}} xmm0 = xmm0[12,13,14,15],zero,zero,zero,zero,zero,zero,zero,zero,xmm0[12,13,14,15]'
+
----------------
Drop this - pshufb probably isn't a perf gain. These tests are more about folding to insertps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list