[llvm] 93be9f0 - [Attributor][FIX] Also update the unit test to match expectations

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 23:24:28 PDT 2022


Author: Johannes Doerfert
Date: 2022-07-22T01:23:55-05:00
New Revision: 93be9f02aac27ec3b0eddacee7dacf58c3c333df

URL: https://github.com/llvm/llvm-project/commit/93be9f02aac27ec3b0eddacee7dacf58c3c333df
DIFF: https://github.com/llvm/llvm-project/commit/93be9f02aac27ec3b0eddacee7dacf58c3c333df.diff

LOG: [Attributor][FIX] Also update the unit test to match expectations

Added: 
    

Modified: 
    llvm/unittests/Transforms/IPO/AttributorTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Transforms/IPO/AttributorTest.cpp b/llvm/unittests/Transforms/IPO/AttributorTest.cpp
index 0d1b04f642c8..cd289a1a2a35 100644
--- a/llvm/unittests/Transforms/IPO/AttributorTest.cpp
+++ b/llvm/unittests/Transforms/IPO/AttributorTest.cpp
@@ -206,8 +206,9 @@ TEST_F(AttributorTestBase, AAReachabilityTest) {
 
   // The first instruction of F9 can reach the first call.
   ASSERT_TRUE(F9AA.instructionCanReach(A, F9FirstInst, F3));
-  // Because func10 calls the func4 after the call to func9 it is reachable.
-  ASSERT_TRUE(F9AA.instructionCanReach(A, F9FirstInst, F4));
+  // Because func10 calls the func4 after the call to func9 it is reachable but
+  // as it requires backwards logic we would need AA::isPotentiallyReachable.
+  ASSERT_FALSE(F9AA.instructionCanReach(A, F9FirstInst, F4));
 }
 
 } // namespace llvm


        


More information about the llvm-commits mailing list