[PATCH] D129533: [ADT] Pass string_view via copy in twine

ppenguin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 20:19:20 PDT 2022


prehistoric-penguin added a comment.

In D129533#3668063 <https://reviews.llvm.org/D129533#3668063>, @RKSimon wrote:

> You're still missing a patch description explaining why pass by value is preferred

Thanks, finally I realize maybe you're referring to the summary part!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129533/new/

https://reviews.llvm.org/D129533



More information about the llvm-commits mailing list