[PATCH] D130319: [Internalize] Support glob patterns for API lists

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/IPO/Internalize.cpp:53
     APIList("internalize-public-api-list", cl::value_desc("list"),
             cl::desc("A list of symbol names to preserve"), cl::CommaSeparated);
 
----------------
Update comment


================
Comment at: llvm/test/Transforms/Internalize/globs.ll:1
+; RUN: opt < %s -internalize -internalize-public-api-list bar?,_*,*_,[ab] -S | FileCheck %s
+
----------------
to avoid gotcha when a user runs the command in a shell.

You can drop `<`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130319/new/

https://reviews.llvm.org/D130319