[PATCH] D130316: [SelectionDAG] make INLINEASM_BR use MachineBasicBlocks instead of BlockAddresses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 18:30:04 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:3641-3644
+  // Retain labels for INLINEASM_BR indirect targets.
+  // TODO: should callers of
+  // MachineBasicBlock::setIsInlineAsmBrIndirectTarget(true) also set
+  // MachineBasicBlock::setLabelMustBeEmitted()?
----------------
Comments can be removed after  D130323?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130316/new/

https://reviews.llvm.org/D130316



More information about the llvm-commits mailing list