[PATCH] D130119: [RISCV] Eagerly delete instructions in MergeBaseOffset.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 14:03:59 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:82
 
 // Detect the pattern:
 //   lui   vreg1, %hi(s)
----------------
asb wrote:
> Comment needs updating to reflect this mutates the MBB rather than just detecting the pattern
This code didn't get updated so I think it is still correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130119/new/

https://reviews.llvm.org/D130119



More information about the llvm-commits mailing list