[llvm] cc0a107 - Fix use after free in MarkupFilter.cpp

[Daniel Thornburgh via llvm-commits]

Author: Daniel Thornburgh
Date: 2022-07-21T13:52:24-07:00
New Revision: cc0a1078f5fb53638e6c125f3be2728dfe84e129

URL: https://github.com/llvm/llvm-project/commit/cc0a1078f5fb53638e6c125f3be2728dfe84e129
DIFF: https://github.com/llvm/llvm-project/commit/cc0a1078f5fb53638e6c125f3be2728dfe84e129.diff

LOG: Fix use after free in MarkupFilter.cpp

Added: 
    

Modified: 
    llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp b/llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
index ce42bbfa31300..91a51485026e0 100644
--- a/llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
+++ b/llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp
@@ -125,15 +125,15 @@ bool MarkupFilter::tryReset(const MarkupNode &Node,
     return true;
 
   if (!Modules.empty() || !MMaps.empty()) {
-    Modules.clear();
-    MMaps.clear();
-
     endAnyModuleInfoLine();
     for (const MarkupNode &Node : DeferredNodes)
       filterNode(Node);
     highlight();
     OS << "[[[reset]]]" << lineEnding();
     restoreColor();
+
+    Modules.clear();
+    MMaps.clear();
   }
   return true;
 }