[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D129519#3669684 <https://reviews.llvm.org/D129519#3669684>, @mysterymath wrote:

> In D129519#3669649 <https://reviews.llvm.org/D129519#3669649>, @mstorsjo wrote:
>
>> This broke building with GCC 9:
>>
>>   In file included from ../tools/llvm-symbolizer/llvm-symbolizer.cpp:23:
>>   ../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:55:19: error: declaration of ‘const llvm::symbolize::MarkupFilter::Module* llvm::symbolize::MarkupFilter::MMap::Module’ changes meaning of ‘Module’ [-fpermissive]
>>      55 |     const Module *Module;
>>         |                   ^~~~~~
>>   ../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:46:10: note: ‘Module’ declared here as ‘struct llvm::symbolize::MarkupFilter::Module’
>>      46 |   struct Module {
>>         |          ^~~~~~
>>   ../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:65:19: error: declaration of ‘const llvm::symbolize::MarkupFilter::Module* llvm::symbolize::MarkupFilter::ModuleInfoLine::Module’ changes meaning of ‘Module’ [-fpermissive]
>>      65 |     const Module *Module;
>>         |                   ^~~~~~
>>   ../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:46:10: note: ‘Module’ declared here as ‘struct llvm::symbolize::MarkupFilter::Module’
>>      46 |   struct Module {
>>         |          ^~~~~~
>
> Sorry about that, see https://github.com/llvm/llvm-project/commit/6605187103a2369418d014a7f146fee4a04b11bf

Thanks, that seems to have done the trick!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519