[PATCH] D128582: Move SeparateConstOffsetFromGEPPass() before LSR() and enable EnableGEPOpt by default.

[Shubham Narlawar via Phabricator via llvm-commits]

gsocshubham added a comment.

In D128582#3669192 <https://reviews.llvm.org/D128582#3669192>, @dmgreen wrote:

> In D128582#3668948 <https://reviews.llvm.org/D128582#3668948>, @gsocshubham wrote:
>
>> There is only one LIT test which is failing now - `CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll`.
>
> It looks like it is removing a unused alloca. Try this:
>
>   index ef559652380e..3fb33ecbb2c7 100644
>   --- a/llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
>   +++ b/llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
>   @@ -1458,10 +1458,12 @@ define void @test_lifetime_intrin() {
>    ; O3-LABEL: name: test_lifetime_intrin
>    ; O3: {{%[0-9]+}}:_(p0) = G_FRAME_INDEX %stack.0.slot
>    ; O3-NEXT: LIFETIME_START %stack.0.slot
>   +; O3-NEXT: G_STORE
>    ; O3-NEXT: LIFETIME_END %stack.0.slot
>    ; O3-NEXT: RET_ReallyLR
>      %slot = alloca i8, i32 4
>      call void @llvm.lifetime.start.p0i8(i64 0, i8* %slot)
>   +  store volatile i8 10, i8* %slot
>      call void @llvm.lifetime.end.p0i8(i64 0, i8* %slot)
>      ret void
>    }

Thanks a lot for this.

Are there any other suggestions on this patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128582/new/

https://reviews.llvm.org/D128582