[PATCH] D130290: [MachineVerifier] add checks for INLINEASM_BR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 11:26:30 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:887-888
+      const MachineBasicBlock *IndirectTargetMBB = nullptr;
+      // TODO: do we have a mapping of BasicBlocks to MachineBasicBlocks
+      // already?
+      for (const MachineBasicBlock &MBB : *MBB->getParent())
----------------
nickdesaulniers wrote:
> I'm probably thinking of `FunctionLoweringInfo`. Not sure how to access one of those from `MachineVerifier`, if it's even possible.
FunctionLowering is for the initial DAG/MIR construction only. I would avoid referring to the underlying IR in any way if possible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130290/new/

https://reviews.llvm.org/D130290



More information about the llvm-commits mailing list