[PATCH] D130282: [llvm][FileCheck] Fix unit tests failures with EXPENSIVE_CHECKS

[Kazu Hirata via Phabricator via llvm-commits]

kazu added a comment.

I am inclined to having the check unconditionally to be more robust.  It is super cheap.  The condition always evaluates to false without `EXPENSIVE_CHECKS`, so it gets along with the branch predictor.  Plus, it would be nice not to rely on the fact that `EXPENSIVE_CHECKS` enables `_GLIBCXX_DEBUG`.  Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130282/new/

https://reviews.llvm.org/D130282