[PATCH] D129561: [RS4GC] Handle special cases in unreachable code for memcpy/memmov

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1706
+        Value *Base = nullptr;
+        // Optimizations in unreachable code might substitute the real pointer
+        // with undef, poison or null-derived constant.
----------------
I would add to the comment that taking null as a base is consistent with the handling in the main algorithm in findBaseDefiningValue. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129561/new/

https://reviews.llvm.org/D129561