[PATCH] D128582: Move SeparateConstOffsetFromGEPPass() before LSR() and enable EnableGEPOpt by default.

Shubham Narlawar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 08:34:52 PDT 2022


gsocshubham added a comment.

In D128582#3668948 <https://reviews.llvm.org/D128582#3668948>, @gsocshubham wrote:

> Fixed review comments.
>
> There is only one LIT test which is failing now - `CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll`.

Regarding `CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll`, it is failing due to change in GEP representation. There are -O0 and -O3 checks from which -O3 checks are failing due to change in GEP representation. I tried to update testcase using - `../../../../utils/update_mir_test_checks.py --llc-binary=../../../../../install/bin/llc arm64-irtranslator.ll` due to which checks had been updated but now -O0 checks are failing. The testcase contains 6k lines and is difficult to update manually.

I used this option to just update O3 <https://reviews.llvm.org/owners/package/3/> checks but that is not helping -
`../../../../utils/update_mir_test_checks.py --llc-binary=../../../../../install/bin/llc arm64-irtranslator.ll --filter O3`

How do I just update O3 <https://reviews.llvm.org/owners/package/3/> checks for testcase `CodeGen/AArch64/GlobalISel/arm64-irtranslator.l`? I have updated `CodeGen/AArch64/GlobalISel/arm64-irtranslator-gep.ll` using `utils/update_mir_test_checks.py` successfully.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128582/new/

https://reviews.llvm.org/D128582



More information about the llvm-commits mailing list