[PATCH] D130053: [WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/tls-local-exec.ll:94
 
- at tls_external = external thread_local(localexec) global i32, align 4
+ at tls_external = external thread_local global i32, align 4
 
----------------
Shouldn't we leave this file as is, with the explicit TLS model?   (according the language reference the default thread model is general dynamic: https://llvm.org/docs/LangRef.html#thread-local-storage-models "If no explicit model is given, the “general dynamic” model is used.").

I guess you are trying to test here that general dynamic is treated "as if" its local-exec,  but we also want to test how the explicit local-exec works, no?    Would we use a macro to and run this entire test with `(localexec)` and with the empty string to check they produce the same results?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130053/new/

https://reviews.llvm.org/D130053