[PATCH] D130170: [AMDGPU] Stop running IR code sinking pass

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:47:10 PDT 2022


piotr added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/sink-image-sample.ll:4
-
-; Test that image.sample instruction is sunk across the branch and not left in the first block. Since the kill may terminate the shader there might be no need for sampling the image.
-
----------------
foad wrote:
> This is no longer done by the codegen pipeline, by design.
> 
> Instead of removing this test I suppose we could change the RUN line to do "opt -sink" or "opt -sink | llc"?
Yes, that would make sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130170/new/

https://reviews.llvm.org/D130170



More information about the llvm-commits mailing list