[PATCH] D128839: [DirectX backend] Add createHandle BufferLoad/Store DXIL operation

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:10:03 PDT 2022


beanz added a comment.

This change adds a bunch of functionality with no tests. How are the new dxil ops generated?

I feel like you have two changes going in here at once. One is a refactor that is probably NFC, and the other is adding some operations that aren't used anywhere. These should be two separate changes, and we shouldn't add the operations until we have codegen in place so that we know how we're going to generate them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128839/new/

https://reviews.llvm.org/D128839



More information about the llvm-commits mailing list