[PATCH] D130252: [RISCV] Precommit test for D130251

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor about test names (sorry I just find it difficult to keep test files 'tidy' with names like test1 ... test2 ... test_3 etc.).



================
Comment at: llvm/test/CodeGen/RISCV/rotl-rotr.ll:325
 
+define i32 @rotl_32_mask_1(i32 %x, i32 %y) nounwind {
+; RV32I-LABEL: rotl_32_mask_1:
----------------
for test names - its better to use real numbers based off the mask instead of just iterating the test#

so maybe rotl_32_mask_63_mask_31 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130252/new/

https://reviews.llvm.org/D130252