[PATCH] D130258: [AMDGPU] Remove IR SpeculativeExecution pass from codegen pipeline

Thu Jul 21 06:09:35 PDT 2022

arsenm added a comment.

In D130258#3668442 <https://reviews.llvm.org/D130258#3668442>, @foad wrote:

> In D130258#3668409 <https://reviews.llvm.org/D130258#3668409>, @arsenm wrote:
>
>> I doubt we actually want to remove this
>
> Can you explain why it was added (D20304 <https://reviews.llvm.org/D20304> does not say) or what it does that does not get undone by code sinking?

I remember sorely needing this for a long time, and it was added specifically for GPUs. I think we would need compelling benchmarks that it doesn't do anything. It's possible SimplifyCFG has gotten more aggressive since this was added?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130258/new/

https://reviews.llvm.org/D130258