[PATCH] D130208: [lld-macho] Fix assertion when two symbols at same addr have unwind info

Thu Jul 21 05:50:19 PDT 2022

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Stamp, but:

================
Comment at: lld/MachO/InputFiles.cpp:1536
+      // infrequently (only when handling the output of `ld -r`).
+      funcSym = findSymbolAtOffset(cast<ConcatInputSection>(funcSym->isec),
+                                   funcSym->value);
----------------
We hit this assert in "normal" builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1346125#c1

Do you want a repro file for that?

Anyways, addressing the assert quickly would be good :) (either revert if hitting this on a normal build is surprising and needs more investigation, or by landing this fix here)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130208/new/

https://reviews.llvm.org/D130208