[PATCH] D129935: [TableGen] Add a location for a class definition that was forward-declared

[Roman Rusyaev via Phabricator via llvm-commits]

rusyaev-roman added a comment.

In D129935#3668112 <https://reviews.llvm.org/D129935#3668112>, @nhaehnle wrote:

> My concern here is with the behavior of PrintMessage and friends. The original change would produce misleading output there. WIth the current change, PrintMessage will print the location of the definition (if it is known).

I see what you mean and it's reasonable. But I think that it's better to hold all locations for the record and decide what to report at a user side. Maybe I'll prepare a related patch in the future, because I feel that introducing 'forward declaration' field is redundant in this case.

Also, I'm going to improve `ctags` support for `tablegen` a little bit more in the future.

Anyway, thanks for merging and some suggestions!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129935/new/

https://reviews.llvm.org/D129935