[PATCH] D129533: [ADT] Pass string_view via copy in twine

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 03:54:01 PDT 2022


RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.

You're still missing a patch description explaining why pass by value is preferred


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129533/new/

https://reviews.llvm.org/D129533



More information about the llvm-commits mailing list