[PATCH] D130119: [RISCV] Eagerly delete instructions in MergeBaseOffset.

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

The change seems functionally correct to me, and the reasoning for the change makes sense. I think the comments for each modified function just need to be updated.



================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:82
 
 // Detect the pattern:
 //   lui   vreg1, %hi(s)
----------------
Comment needs updating to reflect this mutates the MBB rather than just detecting the pattern


================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:128
 
 // Detect patterns for large offsets that are passed into an ADD instruction.
 //
----------------
Comment needs updating to reflect this mutates the MBB rather than just detecting the pattern


================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:201
 
 // Detect patterns for offsets that are passed into a SHXADD instruction.
 // The offset has 1,2, or 3 trailing zeros and fits in simm13, simm14, simm15.
----------------
Comment needs updating to reflect this mutates the MBB rather than just detecting the pattern


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130119/new/

https://reviews.llvm.org/D130119