[PATCH] D130230: [llvm][IROutliner] Account for return void in sort comparator
David Spickett via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 21 01:41:19 PDT 2022
DavidSpickett added a comment.
The thing I'm not sure of here is if we should ever expect to have >1 item in the map if there is a "ret void". Or if it is one of two states:
- one ret void
- multiple return constant integer
I'm not familiar enough with this area to know that. If it's like that then it's probably better to say if EXPENSIVE_CHECKS defined and size is 1, skip the sort entirely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130230/new/
https://reviews.llvm.org/D130230
More information about the llvm-commits
mailing list