[PATCH] D130215: [DebugInfo] Teach dwarfdump and lldb about ptrauth DWARF tags and attributes

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:228
 HANDLE_DW_TAG(0x4200, APPLE_property, 0, APPLE, DW_KIND_NONE)
+HANDLE_DW_TAG(0x4300, LLVM_ptrauth_type, 0, APPLE, DW_KIND_NONE)
 
----------------
This section of the file seems to be in numerical value order, so this tag needs to be after the SUN* tags.

Has the value been finalised, and is the `APPLE` bit of this line correct (it might be, I'm not all that familiar with the tags)? It seems odd putting it here when we already have another block of LLVM tags (well one tag) further down which surely should be extended, rather than adding a second block?


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:601-606
+HANDLE_DW_AT(0x3e04, LLVM_ptrauth_key, 0, APPLE)
+HANDLE_DW_AT(0x3e05, LLVM_ptrauth_address_discriminated, 0, APPLE)
+HANDLE_DW_AT(0x3e06, LLVM_ptrauth_extra_discriminator, 0, APPLE)
 HANDLE_DW_AT(0x3e07, LLVM_apinotes, 0, APPLE)
+HANDLE_DW_AT(0x3e08, LLVM_ptrauth_isa_pointer, 0, APPLE)
+HANDLE_DW_AT(0x3e09, LLVM_ptrauth_authenticates_null_values, 0, APPLE)
----------------
Is `APPLE` actually correct here? These are LLVM attributes after all. Labelling them as coming from APPLE vendors seems wrong?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130215/new/

https://reviews.llvm.org/D130215