[PATCH] D129495: [Orc][JITLink] JITLinkMemoryManager implementation using MemoryMapper
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 20 16:53:45 PDT 2022
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Otherwise LGTM.
================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/MemoryMapper.h:85
+
+ static Expected<std::unique_ptr<InProcessMemoryMapper>> create();
+
----------------
Create methods _usually_ buck the method naming convention and use an uppercase 'C' to emphasize that they're named constructors (though honestly there's plenty of instances of both styles in the codebase). Since ORC more consistently uses upper-case 'C', we should stick with that for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129495/new/
https://reviews.llvm.org/D129495
More information about the llvm-commits
mailing list