[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 15:35:17 PDT 2022


python3kgae created this revision.
python3kgae added reviewers: Anastasia, kuhar, bogner, beanz, pow2clk.
Herald added a subscriber: hiraditya.
Herald added a project: All.
python3kgae requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Put DXIL validation version into separate NamedMetadata to avoid update ModuleFlags.

Currently DXIL validation version is saved in ModuleFlags in clang codeGen.
Then in DirectX backend, the data will be extracted from ModuleFlags and cause rebuild of ModuleFlags.
This patch will build NamedMetadata for DXIL validation version and remove the code to rebuild ModuleFlags.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130207

Files:
  clang/lib/CodeGen/CGHLSLRuntime.cpp
  clang/test/CodeGenHLSL/validator_version.hlsl
  llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp
  llvm/test/CodeGen/DirectX/dxil_ver.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130207.446283.patch
Type: text/x-patch
Size: 4601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220720/565f27cb/attachment.bin>


More information about the llvm-commits mailing list