[PATCH] D130090: [PowerPC][NFC] Convert the MMA test cases to use opaque pointers.

[Amy Kwan via Phabricator via llvm-commits]

amyk added a comment.

I agree with Lei - LGTM, with some minor questions.



================
Comment at: llvm/test/CodeGen/PowerPC/mma-integer-based-outer-product.ll:10
 ; Function Attrs: nofree nounwind writeonly
-define dso_local void @test1(i8* nocapture readnone %vqp, i8* nocapture readnone %vpp, <16 x i8> %vc, i8* nocapture %resp) {
+define dso_local void @test1(ptr nocapture readnone %vqp, ptr nocapture readnone %vpp, <16 x i8> %vc, ptr nocapture %resp) {
 ; CHECK-LABEL: test1:
----------------
If `%vqp` and `%vpp` are not used, do we still need to keep them?


================
Comment at: llvm/test/CodeGen/PowerPC/mma-integer-based-outer-product.ll:40
 ; Function Attrs: nofree nounwind writeonly
-define dso_local void @test2(i8* nocapture readnone %vqp, i8* nocapture readnone %vpp, <16 x i8> %vc, i8* nocapture %resp) {
+define dso_local void @test2(ptr nocapture readnone %vqp, ptr nocapture readnone %vpp, <16 x i8> %vc, ptr nocapture %resp) {
 ; CHECK-LABEL: test2:
----------------
If `%vqp` and `%vpp` are not used, do we still need to keep them?


================
Comment at: llvm/test/CodeGen/PowerPC/mma-integer-based-outer-product.ll:70
 ; Function Attrs: nofree nounwind
-define dso_local void @test3(i8* nocapture readonly %vqp, i8* nocapture readnone %vpp, <16 x i8> %vc, i8* nocapture %resp) {
+define dso_local void @test3(ptr nocapture readonly %vqp, ptr nocapture readnone %vpp, <16 x i8> %vc, ptr nocapture %resp) {
 ; CHECK-LABEL: test3:
----------------
If `%vpp` is not used, do we still need to keep them? (Here and in the functions below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130090/new/

https://reviews.llvm.org/D130090